[Buildroot] [PATCH 05/10] package/systemd: cosmetic rearrange list of users

Jérémy ROSEN jeremy.rosen at smile.fr
Fri Feb 7 12:53:34 UTC 2020


Le ven. 7 févr. 2020 à 13:47, Norbert Lange <nolange79 at gmail.com> a écrit :

> Not sure if you meant to reply to patch #6 instead.
>
> maybe :P


> The main reference is the README, and the templates in sysusers.d.
> You want me to add this as comment in the .mk file if I understood
> correctly?
>
> That's very minor... I meant pointing to the sysusers.d files so someone
that doesn't know systemd as well can check that nothing has changed


> Also I am not sure why those users/groups aren't already in the systemd
> skeleton.
>
> That's a pretty good question. Also, since they are created by
mkusers they have a UID > 1000 that confuses journald.
(they get their own journal files, as if they were normal users, instead of
being logged only in the system journals)


> Should I post just an amended Patch #5 or wait a while to redo the series
> once I got feedback for the rest?
>
> Wait for more feedback, that's too minor to have you respin just for that.

Cheers
Jeremy


> Am Fr., 7. Feb. 2020 um 10:13 Uhr schrieb Jérémy ROSEN <
> jeremy.rosen at smile.fr>:
>
>> could you add a line pointing to the corresponding file in
>> systemd's source code (i.e the sysuser file from upstream)
>> that would help future reviewers
>>
>> apart from that
>>
>> Reviewed-by: Jérémy Rosen <jeremy.rosen at smile.fr>
>>
>> Le jeu. 6 févr. 2020 à 10:37, Norbert Lange <nolange79 at gmail.com> a
>> écrit :
>>
>>> Signed-off-by: Norbert Lange <nolange79 at gmail.com>
>>> ---
>>>  package/systemd/systemd.mk | 4 +++-
>>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
>>> index b3e83b5d3b..b6bd85f130 100644
>>> --- a/package/systemd/systemd.mk
>>> +++ b/package/systemd/systemd.mk
>>> @@ -428,10 +428,12 @@ define SYSTEMD_INSTALL_IMAGES_CMDS
>>>  endef
>>>
>>>  define SYSTEMD_USERS
>>> +       # udev user groups
>>>         - - input -1 * - - - Input device group
>>> -       - - systemd-journal -1 * - - - Journal
>>>         - - render -1 * - - - DRI rendering nodes
>>>         - - kvm -1 * - - - kvm nodes
>>> +       # systemd user groups
>>> +       - - systemd-journal -1 * - - - Journal
>>>         $(SYSTEMD_REMOTE_USER)
>>>         $(SYSTEMD_COREDUMP_USER)
>>>         $(SYSTEMD_NETWORKD_USER)
>>> --
>>> 2.24.1
>>>
>>> _______________________________________________
>>> buildroot mailing list
>>> buildroot at busybox.net
>>> http://lists.busybox.net/mailman/listinfo/buildroot
>>>
>>
>>
>> --
>> [image: SMILE]  <http://www.smile.eu/>
>>
>> 20 rue des Jardins
>> 92600 Asnières-sur-Seine
>> *Jérémy ROSEN*
>> Architecte technique
>>
>> [image: email] jeremy.rosen at smile.fr
>> [image: phone]  +33 6 88 25 87 42
>> [image: url] http://www.smile.eu
>>
>> [image: Twitter] <https://twitter.com/GroupeSmile> [image: Facebook]
>> <https://www.facebook.com/smileopensource> [image: LinkedIn]
>> <https://www.linkedin.com/company/smile> [image: Github]
>> <https://github.com/Smile-SA>
>>
>> [image: Découvrez l’univers Smile, rendez-vous sur smile.eu]
>> <https://www.smile.eu/fr/publications/livres-blancs/yocto?utm_source=signature&utm_medium=email&utm_campaign=signature>
>>
>

-- 
[image: SMILE]  <http://www.smile.eu/>

20 rue des Jardins
92600 Asnières-sur-Seine
*Jérémy ROSEN*
Architecte technique

[image: email] jeremy.rosen at smile.fr
[image: phone]  +33 6 88 25 87 42
[image: url] http://www.smile.eu

[image: Twitter] <https://twitter.com/GroupeSmile> [image: Facebook]
<https://www.facebook.com/smileopensource> [image: LinkedIn]
<https://www.linkedin.com/company/smile> [image: Github]
<https://github.com/Smile-SA>

[image: Découvrez l’univers Smile, rendez-vous sur smile.eu]
<https://www.smile.eu/fr/publications/livres-blancs/yocto?utm_source=signature&utm_medium=email&utm_campaign=signature>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200207/1cf7dd76/attachment.html>


More information about the buildroot mailing list