[Buildroot] [PATCH 3/3] support/testing: add runtime test for Crudini (py2 and py3)

[Thomas Petazzoni]

On Wed,  5 Feb 2020 15:11:49 +0100
Titouan Christophe <titouan.christophe at railnova.eu> wrote:

> This also adds the new tests to the gitlab CI configuration.
> 
> Signed-off-by: Titouan Christophe <titouan.christophe at railnova.eu>
> ---
>  .gitlab-ci.yml                                |  2 +
>  support/testing/tests/package/test_crudini.py | 40 +++++++++++++++++++
>  2 files changed, 42 insertions(+)
>  create mode 100644 support/testing/tests/package/test_crudini.py

We like to have an entry in the DEVELOPERS file for tests so that you
receive an e-mail notification when the test fails in our CI.

> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index c0140527db..aa64bb5fee 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -375,6 +375,8 @@ tests.init.test_systemd.TestInitSystemSystemdRwFull: { extends: .runtime_test }
>  tests.init.test_systemd.TestInitSystemSystemdRwIfupdown: { extends: .runtime_test }
>  tests.init.test_systemd.TestInitSystemSystemdRwNetworkd: { extends: .runtime_test }
>  tests.package.test_atop.TestAtop: { extends: .runtime_test }
> +tests.package.test_crudini.TestCrudiniPy2: {extends: .runtime_test}
> +tests.package.test_crudini.TestCrudiniPy3: {extends: .runtime_test}

You wrote this by hand, but it is auto-generated by "make
.gitlab-ci.yml", with a slightly different formatting.

> +class TestCrudiniBase(TestPythonPackageBase):
> +    config = TestPythonPackageBase.config + "\nBR2_PACKAGE_CRUDINI=y"

We like to use multiline strings to add config options.

I've fixed the above issues and applied to master.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com