[Buildroot] [PATCH v2] package/libnspr: remove BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT
giulio.benetti at benettiengineering.com
Tue Feb 4 14:49:31 UTC 2020
Hi Arnout, All,
On 2/4/20 3:36 PM, Arnout Vandecappelle wrote:
> On 04/02/2020 11:04, Thomas Petazzoni wrote:
>> On Tue, 4 Feb 2020 10:50:59 +0100
>> Giulio Benetti <giulio.benetti at benettiengineering.com> wrote:
>>> Since all architectures supported by Buildroot are supported by libnspr
>>> BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT makes no sense anymore, so let's remove
>>> it all around.
>>> Signed-off-by: Giulio Benetti <giulio.benetti at benettiengineering.com>
>> Arnout and I both agreed that we want to keep this blind option, so I'm
>> not sure I understand why you're sending this patch. Did we miss something?
> Actually, Giulio replied that in the other thread (but it should be part of the
> commit log here, maybe): adding architecture support is trivial (just a matter
> of defining the right sizes), so we should never need to re-add this option.
> Just fix libnspr.
Oops, again, sorry, I was on Mobile.
Anyway yes, to add support for new architecture in nspr it's enough add
2 entries as you can see on my previous upstreamed patch:
But IMHO if a new architecture is added to Buildroot nspr will fail to
build for it, but fix it(*at the moment at least*) is trivial.
Thank you Arnout for pointing.
Benetti Engineering sas
> buildroot mailing list
> buildroot at busybox.net
More information about the buildroot