[Buildroot] [PATCH v3 for-next 00/11] gitlab Qemu runtime testing
Arnout Vandecappelle
arnout at mind.be
Tue Feb 4 14:31:59 UTC 2020
On 04/02/2020 14:59, Romain Naour wrote:
> Hi,
>
> Le 19/12/2019 à 12:11, Peter Korsgaard a écrit :
>>>>>>> "Arnout" == Arnout Vandecappelle <arnout at mind.be> writes:
>>
>> Hi,
>>
>> >> I discussed about this series with Jeremy and he suggest to add the Qemu command
>> >> line into the Qemu's defconfig file (add a new Kconfig option).
>> >> With that, we can even add a new Makefile target "make run-qemu" to start Qemu
>> >> when the Qemu command line is set in the defconfig (this would avoid adding
>> >> several launch.sh script).
>>
>> > So something like
>>
>> > config BR2_PACKAGE_HOST_QEMU_LAUNCH_ARGS
>> > string "qemu launch command"
>> > help
>> > Command to launch qemu. If this is defined, 'make run-qemu' can be
>> > used to build everything and launch qemu.
>>
>>
>> > HOST_QEMU_LAUNCH_ARGS = $(call qstrip,$(BR2_PACKAGE_HOST_QEMU_LAUNCH_ARGS))
>> > ifneq ($(HOST_QEMU_LAUNCH_ARGS),)
>> > run-qemu: world
>> > $(Q)$(HOST_QEMU) <kernel args> <rootfs args> $(HOST_QEMU_LAUNCH_ARGS)
>> > endif
>>
>> > Looks like a good idea indeed!
>>
>> Cute. The kernel arguments (-kernel path/to/kernel/image) could indeed
>> probably be standardized, but we do some to have quite some variation in
>> the rootfs arguments.
>>
>> But OK, we could start with just including the rootfs argument in
>> _LAUNCH_ARGS.
>>
>
> About the qemu-system-* binary, should we use the one from the host or use the
> one from the host-qemu package? (or it depend?)
>
> It can be convenient to use the Qemu provided by the host since it can provide
> full feature support. The Qemu provided by host-qemu only support some
> dependencies but not all.
>
> On the other hand, the user can still use the qemu-system-* he want by not using
> make run-qemu but using the qemu command line in the console.
Indeed. I think the 'run-qemu' should be something completely self-contained
and not rely on anything on the build machine.
So I think we should use host-qemu.
Regards,
Arnout
More information about the buildroot
mailing list