[Buildroot] [PATCH 2/2] boot/uboot: needs make >= 4.0

Peter Korsgaard peter at korsgaard.com
Mon Feb 3 20:30:42 UTC 2020


>>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:

 > Starting with 2020.01, uboot started using the 'undefine' make
 > directive, which was only introduced with make 4.0.

 > In the general case, we do not have a way to know if the uboot
 > selected by the user is older or later than 2020.01, so we have
 > no way to know before hand if make >= 4.0 is needed or not. As
 > such, we have no other option than to always require it.

 > So, use the existing $(BR2_MAKE_HOST_DEPENDENCY) and $(BR2_MAKE),
 > both of each will ensure that we do use a make that is at least 4.0.

 > Reported-by: Peter Korsgaard <peter at korsgaard.com>
 > Signed-off-by: Yann E. MORIN <yann.morin.1998 at free.fr>
 > ---
 >  boot/uboot/uboot.mk | 6 ++++--
 >  1 file changed, 4 insertions(+), 2 deletions(-)

 > diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
 > index a4879bb8b2..19dfb08e81 100644
 > --- a/boot/uboot/uboot.mk
 > +++ b/boot/uboot/uboot.mk
 > @@ -12,6 +12,8 @@ UBOOT_LICENSE_FILES = Licenses/gpl-2.0.txt
 
 >  UBOOT_INSTALL_IMAGES = YES
 > +UBOOT_DEPENDENCIES = $(BR2_MAKE_HOST_DEPENDENCY)

I added a comment explaining why we are doing this and committed,
thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list