[Buildroot] [PATCH] package/meson: fix shabang in deep build trees

Peter Korsgaard peter at korsgaard.com
Mon Feb 3 11:08:31 UTC 2020


>>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:

 > The meson script includes the full path to the python interpreter. In
 > deep build trees, this path can be more than 128 characters long, which
 > is the limit a shabang might be.

NIT: It is called shebang, not shabang.

NIT2: This has actually been bumped to 256 bytes in linux 5.1:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6eb3c3d0a52dca337e327ae8868ca1f44a712e02

 > +# Avoid interpreter shabang longer than 127 chars

127? Off by one? ;) In fact, 128 bytes is the size of the entire buffer
read from the file, so including the leading #! and trailing \0 and the
actual path can AFAIK only be 125 bytes long. I changed it to 128 for
consistency.

Committed with these minor fixes, thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list