[Buildroot] [PATCH v2 2/4] package/kodi: add optional support for wayland

Thomas Petazzoni thomas.petazzoni at bootlin.com
Mon Feb 3 10:26:02 UTC 2020


Hello,

On Sun,  2 Feb 2020 18:33:31 +0100
Bernd Kuhls <bernd.kuhls at t-online.de> wrote:

> For details see upstream PR 12664.
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls at t-online.de>

I've applied, with a few changes, see below.

> +config BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_WAYLAND_GL
> +	bool
> +	default y

I've added a

	depends on BR2_PACKAGE_HAS_LIBGL

cause you then depend on "libgl".

> +	depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND # waylandpp
> +	depends on BR2_HOST_GCC_AT_LEAST_4_9 # waylandpp
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # waylandpp
> +	depends on BR2_PACKAGE_WAYLAND # waylandpp
> +	select BR2_PACKAGE_WAYLANDPP

You should not add such selects to blind options that are "default y".
Indeed here, waylandpp is going to be selected as soon as all the
dependencies of this option are met, regardless of whether you really
enable Kodi's Wayland backend.

So I moved the select to BR2_PACKAGE_KODI_PLATFORM_WAYLAND_GL.

> +config BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_WAYLAND_GLES
> +	bool
> +	default y
> +	depends on BR2_PACKAGE_HAS_LIBGLES
> +	depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND # waylandpp
> +	depends on BR2_HOST_GCC_AT_LEAST_4_9 # waylandpp
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # waylandpp
> +	depends on BR2_PACKAGE_WAYLAND # waylandpp
> +	select BR2_PACKAGE_WAYLANDPP

Ditto here.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list