[Buildroot] [PATCH/RFC 1/1] package/libiconv: enable extra encodings
arnout at mind.be
Sat Feb 1 10:52:36 UTC 2020
On 29/01/2020 11:50, Thomas Petazzoni wrote:
> On Tue, 28 Jan 2020 23:21:40 +0100
> Bernd Kuhls <bernd.kuhls at t-online.de> wrote:
>> Quoting https://www.gnu.org/software/libiconv/
>> "When configured with the option --enable-extra-encodings, it also
>> provides support for a few extra encodings:
>> European languages
>> Semitic languages
>> EUC-JISX0213, Shift_JISX0213, ISO-2022-JP-3
>> BIG5-2003 (experimental)
>> Platform specifics
>> ATARIST, RISCOS-LATIN1"
>> Updating Kodi from version 17.6 to 18.5 caused runtime errors on systems
>> with locale support disabled, here Kodi uses libiconv but needs CP437:
>> ERROR: customConvert: iconv_open() for "CP437" -> "UTF-8" failed,
>> errno = 22 (Invalid argument)
>> The size of libiconv.so.2.6.0 grows from 941K to 1,1M.
>> Signed-off-by: Bernd Kuhls <bernd.kuhls at t-online.de>
> In the Kodi use case, a size increase of 160 KB is not important
> obviously, but libiconv is also used in other situations where size
> might matter. I don't have a very strongly formed opinion on this, but
> perhaps this is a case where a Config.in sub-option might be useful,
> which would be selected by Kodi. Please wait a bit for others feedback
> before implementing this though, as others may disagree.
I agree. Even if it's only a 15% growth of the packages, so probably about 5%
growth overall in a minimal case, libiconv is often a dependency you don't
really want to have but just are forced to. So any size increase is unwanted.
So yes, please make this optional.
More information about the buildroot