[Buildroot] [PATCH 2/2] Defconfigs: fix rock64_defconfig

Romain Naour romain.naour at gmail.com
Mon Dec 14 22:08:06 UTC 2020


Hello Min,

Adding Michal in Cc.

Le 14/12/2020 à 20:23, Min Xu a écrit :
> Signed-off-by: Min Xu <xuminready at gmail.com>

Please squash your two patches since you add again this defconfig with an
updated BSP. As explained in the commit log [1] the rock64 defconfig was removed
since it was broken for a long time due to a too old uboot version (2017.09).

Also this is not really a fix since you bump uboot from 2017.09 to 2020.07 from
ayufan-rock64 fork.

[1] a5fa2469e6506ea4f5a91739aa099f63a10e45ce

Best regards,
Romain


> ---
>  configs/rock64_defconfig | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/configs/rock64_defconfig b/configs/rock64_defconfig
> index 30bf12c061..df03e357e2 100644
> --- a/configs/rock64_defconfig
> +++ b/configs/rock64_defconfig
> @@ -17,16 +17,16 @@ BR2_TARGET_ROOTFS_EXT2=y
>  BR2_TARGET_ROOTFS_EXT2_4=y
>  BR2_TARGET_ROOTFS_EXT2_SIZE="128M"
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
> -BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION=y
> -BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE="v1.4"
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="rk3328"
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES="bl31/*.elf"
>  BR2_TARGET_UBOOT=y
>  BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
>  BR2_TARGET_UBOOT_CUSTOM_GIT=y
> -BR2_TARGET_UBOOT_CUSTOM_REPO_URL="https://github.com/ayufan-rock64/linux-u-boot.git"
> -BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="2017.09-rockchip-ayufan-1035-gd646df03ac"
> +BR2_TARGET_UBOOT_CUSTOM_REPO_URL="https://github.com/ayufan-rock64/linux-mainline-u-boot.git"
> +BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="release-2020-07"
>  BR2_TARGET_UBOOT_BOARD_DEFCONFIG="rock64-rk3328"
>  BR2_TARGET_UBOOT_NEEDS_DTC=y
> +BR2_TARGET_UBOOT_NEEDS_PYTHON3=y
>  BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
>  BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
>  BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF=y
> 



More information about the buildroot mailing list