[Buildroot] [PATCH v4 1/4] package/pkg-qmake: adding FOO_SYNC_HEADERS

[Thomas Petazzoni]

On Tue, 24 Nov 2020 07:59:14 +0100
Angelo Compagnucci <angelo at amarulasolutions.com> wrote:

> Some qmake based packages need to call the syncqt.pl script before
> building to have a properly populated "include" directory inside
> the package build tree.
> This script is automatically executed by qmake when a source tree
> is from a git clone: buildroot purges the .git directory hence the
> script never runs.
> 
> Signed-off-by: Angelo Compagnucci <angelo at amarulasolutions.com>

Thanks! I have applied this, but after doing some changes. First, I
renamed the variable to <pkg>_SYNC_QT_HEADERS.

> +ifdef $(2)_SYNC_HEADERS

Changed to ifeq (..., YES). Indeed, with an ifdef, even setting
SYNC_HEADERS = NO would have triggered the thing, which would have not
been expected.

> +$(2)_DEPENDENCIES 		+= host-perl
> +endif
> +
>  #
>  # Configure step. Only define it if not already defined by the package
>  # .mk file.
> @@ -52,6 +56,7 @@ ifndef $(2)_CONFIGURE_CMDS
>  define $(2)_CONFIGURE_CMDS
>  	$$(QT5_QT_CONF_FIXUP)
>  	cd $$($(2)_BUILDDIR) && \
> +	$$(if $$($(2)_SYNC_HEADERS), $(HOST_DIR)/bin/syncqt.pl -version $(QT5_VERSION) &&) \

I moved this out into a pre-configure hook, following the model that we
use for running autoreconf on autotools packages.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com