[Buildroot] [PATCH v2 1/1] package/makedumpfile: new package

Jugurtha BELKALEM jugurtha.belkalem at smile.fr
Mon Aug 31 09:04:56 UTC 2020


Hi Alexander,


+config BR2_PACKAGE_MAKEDUMPFILE
> +       bool "makedumpfile"
> +       depends on BR2_TOOLCHAIN_HAS_THREADS
> +       depends on !BR2_STATIC_LIBS # dlopen
> +       depends on BR2_USE_WCHAR
> +       depends on BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC
> +       select BR2_PACKAGE_ELFUTILS
> +       select BR2_PACKAGE_ZLIB
> +       select BR2_PACKAGE_BZIP2
> +       select BR2_PACKAGE_XZ
>
>
Please, select package statement  should be sorted alphabetically.


> +MAKEDUMPFILE_VERSION = 1.6.7
> +MAKEDUMPFILE_SITE =
> https://github.com/makedumpfile/makedumpfile/releases/download/Released-$(subst
> .,-,$(MAKEDUMPFILE_VERSION))
>
Use github download helper :

MAKEDUMPFILE_SITE = $(call
github,makedumpfile,makedumpfile,v$(MAKEDUMPFILE_VERSION))



> +MAKEDUMPFILE_DEPENDENCIES = zlib xz bzip2 elfutils
>

Please, dependencies should be sorted as well.


Best regards,

Jugurtha.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200831/e7466eab/attachment.html>


More information about the buildroot mailing list