[Buildroot] [PATCH 1/1] package/rtty: fix build with mbedtls but without zlib

[Fabrice Fontaine]

Le dim. 30 août 2020 à 22:02, Thomas Petazzoni
<thomas.petazzoni at bootlin.com> a écrit :
>
> On Sun, 30 Aug 2020 21:20:29 +0200
> Fabrice Fontaine <fontaine.fabrice at gmail.com> wrote:
>
> > +-        set(SSL_LIB ${MBEDTLS_LIBRARIES} ${ZLIB_LIBRARIES})
> > ++        if(ZLIB_FOUND)
> > ++            set(SSL_LIB ${MBEDTLS_LIBRARIES} ${ZLIB_LIBRARIES})
>
> Is there a reason why zlib is necessary for mbedtls support ?
zlib is not mandatory with mbedtls, only optional, however as mbedtls
does not provide a pkg-config file, we assume that if zlib is
available, we must link with it to avoid a build failure when linking
statically with a zlib-enabled mbedtls.
This change was pushed upstream with
https://github.com/zhaojh329/rtty/commit/7b8efe11dbafce97971dc130bf6cc1756f34ce07.
However, we missed that this change will raise a build failure if
ZLIB_LIBRARIES is used when zlib is not found.
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,

Fabrice