[Buildroot] [PATCH 1/1] package/ibm-sw-tpm2: enable only on supported architectures

Fabrice Fontaine fontaine.fabrice at gmail.com
Tue Apr 21 09:57:24 UTC 2020


Hi Thomas,

Le mar. 21 avr. 2020 à 11:41, Thomas Petazzoni
<thomas.petazzoni at bootlin.com> a écrit :
>
> On Tue, 21 Apr 2020 11:26:47 +0200
> Fabrice Fontaine <fontaine.fabrice at gmail.com> wrote:
>
> > Fixes:
> >  - http://autobuild.buildroot.org/results/12d2c27c38cc52248d3277995a9bb5eae4b8bb9e
> >  - http://autobuild.buildroot.org/results/34151bded9737f7c128b7a2d763c9e0af8018068
> >  - http://autobuild.buildroot.org/results/9abbbdd2735991277c0b821a47c579b053335caf
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
>
> I was also looking at this issue, and I believe it might be easier to
> really fix the problem.
>
> Indeed, it's just:
>
> #ifndef RADIX_BITS
> #   if defined(__x86_64__) || defined(__x86_64)                         \
>     || defined(__amd64__) || defined(__amd64) || defined(_WIN64) || defined(_M_X64) \
>     || defined(_M_ARM64) || defined(__aarch64__) \
>     || defined(__powerpc64__) || defined(__ppc64__)
> #       define RADIX_BITS                      64
> #   elif defined(__i386__) || defined(__i386) || defined(i386)          \
>     || defined(_WIN32) || defined(_M_IX86)                              \
>     || defined(_M_ARM) || defined(__arm__) || defined(__thumb__)
> #       define RADIX_BITS                      32
> #   else
> #       error Unable to determine RADIX_BITS from compiler environment
> #   endif
> #endif // RADIX_BITS
>
> that causes problems.
>
> And this crap can most likely be replaced by:
>
> #define RADIX_BITS __WORDSIZE
Indeed, then feel free to set my patch as not applicable. Your
solution is better than mine.
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,

Fabrice


More information about the buildroot mailing list