[Buildroot] [PATCH v1 2/6] package/qt5base: drop all legacy gcc requierements below 5.0

Peter Seiderer ps.report at gmx.net
Mon Apr 20 18:35:33 UTC 2020


Hello Thomas,

On Sun, 19 Apr 2020 15:03:05 +0200, Thomas Petazzoni <thomas.petazzoni at bootlin.com> wrote:

> On Sun, 19 Apr 2020 00:59:02 +0200
> Peter Seiderer <ps.report at gmx.net> wrote:
>
> > As qt5 requires as minimum gcc 5.0 drop all legacy requierements below.
> >
> > Signed-off-by: Peter Seiderer <ps.report at gmx.net>
> > ---
> >  package/qt5/qt5base/Config.in | 9 +--------
> >  1 file changed, 1 insertion(+), 8 deletions(-)
>
> I have not applied this one, and neither the remaining patches in the
> series. Indeed, we normally want to propagate "depends on" to all
> reverse dependencies, even if in practice it is already not possible to
> select a given option due to it being hidden by a "depends on" at a
> higher level.
>
> We believe that always duplicating improves consistency and helps
> avoiding mistakes. I agree that we are not 100% consistent on this
> throughout the tree, but the direction we want to go to is to replicate
> these "depends no", not get rid of them.
>
> I agree that this is a very 'opinionated' decision and I am myself a
> bit split between the two possibilities we have. But the overall
> consensus seems to be that we should have that duplication.
>
> So, I've marked PATCH 2/6 to 6/6 as Rejected.

Fine with me ;-), and thanks for the detailed explanation...

Regards,
Peter

>
> Thanks!
>
> Thomas



More information about the buildroot mailing list