[Buildroot] [PATCH] package/matio: new package

Heiko Thiery heiko.thiery at gmail.com
Sun Apr 19 21:02:49 UTC 2020


Hi Gwenhael,

I just have some small comments about the style. See below.

Am Mo., 13. Apr. 2020 um 08:53 Uhr schrieb Gwenhael Goavec-Merou
<gwenj at trabucayre.com>:
>
> From: Gwenhael Goavec-Merou <gwenhael.goavec-merou at trabucayre.com>
>
> matio is an C library for reading and writing MATLAB MAT files.
>
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou at trabucayre.com>
> ---
>  DEVELOPERS               |  1 +
>  package/Config.in        |  1 +
>  package/matio/Config.in  | 14 ++++++++++++++
>  package/matio/matio.hash |  5 +++++
>  package/matio/matio.mk   | 29 +++++++++++++++++++++++++++++
>  5 files changed, 50 insertions(+)
>  create mode 100644 package/matio/Config.in
>  create mode 100644 package/matio/matio.hash
>  create mode 100644 package/matio/matio.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index ac3d89dd0a..a207a750f2 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1096,6 +1096,7 @@ F:        package/gnuradio/
>  F:     package/gqrx/
>  F:     package/gr-osmosdr/
>  F:     package/libusbgx/
> +F:     package/matio/
>  F:     package/python-cheetah/
>  F:     package/python-markdown/
>  F:     package/python-remi/
> diff --git a/package/Config.in b/package/Config.in
> index b5bf4e32d3..f632727015 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1864,6 +1864,7 @@ endif
>         source "package/liquid-dsp/Config.in"
>         source "package/llvm/Config.in"
>         source "package/lttng-libust/Config.in"
> +       source "package/matio/Config.in"
>         source "package/mpc/Config.in"
>         source "package/mpdecimal/Config.in"
>         source "package/mpfr/Config.in"
> diff --git a/package/matio/Config.in b/package/matio/Config.in
> new file mode 100644
> index 0000000000..e1dc96a2ed
> --- /dev/null
> +++ b/package/matio/Config.in
> @@ -0,0 +1,14 @@
> +config BR2_PACKAGE_MATIO
> +       bool "matio"
> +       select BR2_PACKAGE_ZLIB
> +       help
> +         matio is an C library for reading and writing MATLAB MAT
> +         files.

I think there should be a blank line before the project URL.

> +         https://sourceforge.net/projects/matio
> +
> +if BR2_PACKAGE_MATIO
> +
> +config BR2_PACKAGE_MATIO_SPARSE
> +       bool "sparse support"
> +
> +endif
> diff --git a/package/matio/matio.hash b/package/matio/matio.hash
> new file mode 100644
> index 0000000000..d84f50e0b2
> --- /dev/null
> +++ b/package/matio/matio.hash
> @@ -0,0 +1,5 @@
> +# From https://sourceforge.net/projects/matio/files/matio/1.5.17/
> +sha512  af8ff11c7c44fea9ea6886e381f49ef9186946f3def98ad9695f2d5d1df045c35e8f4ceac12a44be397f7bbd708b4803762b5ce54c45b60a9f446d551c04f5d2  matio-1.5.17.tar.gz
> +# Locally computed
> +sha256  5e455527d370ab297c4abe5a2ab4d599c93ac7c1a0c85d841cc5c22f8221c400  matio-1.5.17.tar.gz
> +sha256  62a0cab69eeadb3697a2249d5a869915b89e62b59b794dd70802c2b8624ed374  COPYING
> diff --git a/package/matio/matio.mk b/package/matio/matio.mk
> new file mode 100644
> index 0000000000..02c3733413
> --- /dev/null
> +++ b/package/matio/matio.mk
> @@ -0,0 +1,29 @@
> +################################################################################
> +#
> +# matio
> +#
> +################################################################################
> +
> +MATIO_VERSION = 1.5.17
> +MATIO_SITE = http://downloads.sourceforge.net/project/matio/matio/$(MATIO_VERSION)
> +MATIO_LICENSE = BSD-2-Clause
> +MATIO_LICENSE_FILES = COPYING
> +
> +MATIO_DEPENDENCIES = zlib
> +
> +# For third-party blocks, the matio libraries are mandatory at
> +# compile time.
> +MATIO_INSTALL_STAGING = YES

The blank lines above should be removed and the comment is not needed.
The use of staging should be clear.

> +
> +# va_copy()
> +MATIO_CONF_ENV += ac_cv_va_copy=yes

The '+' can be omitted. Just '=' is ok.

> +
> +MATIO_CONF_OPTS = --enable-mat73=no
> +
> +ifeq ($(BR2_PACKAGE_MATIO_SPARSE),y)
> +MATIO_CONF_OPTS += --enable-extended-sparse=yes
> +else
> +MATIO_CONF_OPTS += --enable-extended-sparse=no
> +endif
> +
> +$(eval $(autotools-package))

-- 
BR,
Heiko


More information about the buildroot mailing list