[Buildroot] [PATCH v2 1/1] package/apcupsd: new package

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sun Apr 19 12:52:46 UTC 2020


On Sat, 18 Apr 2020 18:39:53 -0600
James Hilliard <james.hilliard1 at gmail.com> wrote:

> Apcupsd is a UPS control system that permits orderly shutdown of your
> computer in the event of a power failure.
> 
> Signed-off-by: James Hilliard <james.hilliard1 at gmail.com>

I've applied, after changing the order of the option in Config.in and
their handling in the .mk file so that they are sorted alphabetically.

However, one thing worries me: this package installs a binary called
'smtp' in $(TARGET_DIR)/usr/bin. 'smtp' seems like an awfully generic
name, which could easily clash with another package. Should we rename
that to apcupsd-smtp ? I'm not sure if 'smtp' gets used directly by
apcupsd, or it's only a tool that you can use in apcupsd's
configuration file.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list