[Buildroot] [PATCH 6/8] core/show-info: report package stamp files
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Sat Apr 11 08:38:42 UTC 2020
On Sat, 11 Apr 2020 10:12:31 +0200
"Yann E. MORIN" <yann.morin.1998 at free.fr> wrote:
> + "stamp_files": {
> + $(if $($(1)_OVERRIDE_SRCDIR), \
> + "rsync": "$(notdir $($(1)_TARGET_RSYNC))"$(comma) \
> + , \
> + "download": "$(notdir $($(1)_TARGET_SOURCE))"$(comma) \
> + "extract": "$(notdir $($(1)_TARGET_EXTRACT))"$(comma) \
> + "patch": "$(notdir $($(1)_TARGET_PATCH))"$(comma) \
> + )
> + "configure": "$(notdir $($(1)_TARGET_CONFIGURE))",
> + "build": "$(notdir $($(1)_TARGET_BUILD))",
> + $(if $(filter YES,$($(1)_INSTALL_STAGING)),\
> + "install_staging": "$(notdir $($(1)_TARGET_INSTALL_STAGING))"$(comma) \
> + )
> + $(if $(filter YES,$($(1)_INSTALL_TARGET)),\
> + "install_target": "$(notdir $($(1)_TARGET_INSTALL_TARGET))"$(comma) \
> + )
> + $(if $(filter YES,$($(1)_INSTALL_IMAGES)),\
> + "install_images": "$(notdir $($(1)_TARGET_INSTALL_IMAGES))"$(comma) \
> + )
> + $(if $(filter host,$($(1)_TYPE)), \
> + "install": "$(notdir $($(1)_TARGET_INSTALL_HOST))"$(comma) \
> + )
Isn't this going to add for each package exactly the same information,
over and over again ? I.e, just the names of stamp files, again, again,
and again. This seems like a big waste of space, making the JSON output
very noisy. I think the tool showing the progress should simply know
what the stamp files are.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
More information about the buildroot
mailing list