[Buildroot] [PATCH] toolchain/toolchain-external: fix call to check_kernel_headers_version
Peter Korsgaard
peter at korsgaard.com
Mon Apr 6 15:16:41 UTC 2020
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at bootlin.com> writes:
> The external toolchain configure step calls the
> check_kernel_headers_version make function to compare the kernel
> headers version declared in the configuration with the actual kernel
> headers of the toolchain.
> This function takes 4 arguments, but due to a missing comma what
> should be the first two arguments are both passed into the first
> argument. Due to this, when check_kernel_headers_version does:
> if ! support/scripts/check-kernel-headers.sh $(1) $(2) $(3) \
> $(if $(BR2_TOOLCHAIN_HEADERS_LATEST),$(4),strict); \
> Then:
> $(1) contains "$(BUILD_DIR) $$(call toolchain_find_sysroot,$$(TOOLCHAIN_EXTERNAL_CC))"
> $(2) contains "$$(call qstrip,$$(BR2_TOOLCHAIN_HEADERS_AT_LEAST))"
> $(3) contains "$$(if $$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM),loose,strict))"
> So from the point of view of check-kernel-headers.sh, it already has
> four arguments, and therefore the additional argument passed by:
> $(if $(BR2_TOOLCHAIN_HEADERS_LATEST),$(4),strict); \
> is ignored, defeating the $(BR2_TOOLCHAIN_HEADERS_LATEST) test.
> The practical consequence is that a toolchain that has 5.4 kernel
> headers but declared as using 5.3 kernel headers does not abort the
> build, because the check is considered "loose" while it should be
> "strict".
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
Committed to 2019.02.x, 2019.11.x and 2020.02.x, thanks (the first two
do not support the strict/loose match though)
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list