[Buildroot] [PATCH 1/1] package/xdebug: new package

[Thomas Petazzoni]

On Mon, 23 Sep 2019 15:27:21 +0200
Arnout Vandecappelle <arnout at mind.be> wrote:

> > diff --git a/package/Config.in b/package/Config.in
> > index 2fc11065f6..95115ec469 100644
> > --- a/package/Config.in
> > +++ b/package/Config.in
> > @@ -141,6 +141,7 @@ menu "Debugging, profiling and benchmark"
> >  	source "package/valgrind/Config.in"
> >  	source "package/vmtouch/Config.in"
> >  	source "package/whetstone/Config.in"
> > +	source "package/xdebug/Config.in"  
> 
>  Hm. IIUC, this is really a PHP extension, *not* a debugger that happens to use
> PHP internally. Therefore, I would think that it fits more in the "External php
> extensions" menu.

Agreed, if it's a PHP extension, it should go in the PHP extensions
menu, and be called "php-xdebug".

> > index 0000000000..c0abb71896
> > --- /dev/null
> > +++ b/package/xdebug/Config.in
> > @@ -0,0 +1,7 @@
> > +config BR2_PACKAGE_XDEBUG
> > +	bool "xdebug"
> > +	select BR2_PACKAGE_PHP  
> 
>  If you select a package, you have to copy its dependencies.
> 
>  However, for a PHP package, it's more appropriate to depend on it I think. Note
> that if you move it to the external php extensions menu that dependency will be
> implicit.

If it goes in the PHP extensions menu, then it will automatically be
inside a "if BR2_PACKAGE_PHP...endif" block.

>  Note also that normally, PHP extensions can only be built for !STATIC. Did you
> run test-pkg?

... and in a if !BR2_STATIC_LIBS..endif block.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com