[Buildroot] [PATCH] package/pkg-utils.mk: add dl_dir to show-info output
Yann E. MORIN
yann.morin.1998 at free.fr
Sun Sep 22 11:54:19 UTC 2019
Arnout, All,
Sorry for the long delay in reviewing this. One minor comment below...
On 2019-08-03 15:49 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> It can be useful for scripts to be able to access a package's source
> file after download. That used to be easy, just DL_DIR/PKG_SOURCE.
> However, with the subdirectories in DL_DIR which can be overridden with
> PKG_DL_SUBDIR, that is no longer easy.
>
> Therefore, this patch adds dl_dir to the package information. It prints
> just PKG_DL_SUBDIR, to avoid dumping absolute paths to the buildroot
> directory in the show-info output.
>
> It can be used with the following jq script to get a newline-separated
> list of all downloaded files:
>
> make show-info | jq -r '.[] | ("dl/" + .dl_dir + "/" + .downloads[]?.source)'
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
> Cc: Yann E. MORIN <yann.morin.1998 at free.fr>
> ---
> v1 -> v2:
> - Use DL_SUBDIR (i.e. relative path) instead of DL_DIR (i.e. absolute
> path). (Yann)
> - Move the definition one level higher, because it is anyway the same
> for all sources. (Yann)
> - Update jq script in commit message to handle the above.
> ---
> package/pkg-utils.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
> index b7280e930f..d3345f7c91 100644
> --- a/package/pkg-utils.mk
> +++ b/package/pkg-utils.mk
> @@ -94,6 +94,7 @@ endef
> define _json-info-pkg-details
> "version": "$($(1)_DL_VERSION)",
> "licenses": "$($(1)_LICENSE)",
> + "dl_dir": "$($(1)_DL_SUBDIR)",
> "downloads": [
> $(foreach dl,$(sort $($(1)_ALL_DOWNLOADS)),
> {
> @@ -104,8 +105,7 @@ define _json-info-pkg-details
> $(call DOWNLOAD_URIS,$(dl),$(1))
> )
> )
> - ]
> - },
> + ] },
Spurious unrelated change, I'm afraid... Otherwise:
Acked-by: Yann E. MORIN <yann.morin.1998 at free.fr>
Regards,
Yann E. MORIN.
> )
> ],
> endef
> --
> 2.21.0
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list