[Buildroot] [PATCH 1/1] package/libspatialindex: bump to version 1.9.0

Fabrice Fontaine fontaine.fabrice at gmail.com
Sat Sep 21 19:33:28 UTC 2019


Dear Arnout,

Le sam. 21 sept. 2019 à 21:18, Arnout Vandecappelle <arnout at mind.be> a écrit :
>
>  Hi Fabrice,
>
> On 21/09/2019 20:35, Fabrice Fontaine wrote:
> > - Switch site to github to get latest version
> > - Switch to cmake to be able to disable tests
> > - Drop patch (already in version)
> > - Add hash for license file
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> > ---
> >  .../0001-configure.ac-do-not-force-O2.patch   | 30 -------------------
> >  package/libspatialindex/libspatialindex.hash  |  9 +++---
> >  package/libspatialindex/libspatialindex.mk    | 11 ++++---
> >  3 files changed, 10 insertions(+), 40 deletions(-)
> >  delete mode 100644 package/libspatialindex/0001-configure.ac-do-not-force-O2.patch
> >
> [snip]
> > diff --git a/package/libspatialindex/libspatialindex.mk b/package/libspatialindex/libspatialindex.mk
> > index 8dd85e2700..f5a6d3acac 100644
> > --- a/package/libspatialindex/libspatialindex.mk
> > +++ b/package/libspatialindex/libspatialindex.mk
> > @@ -4,15 +4,14 @@
> >  #
> >  ################################################################################
> >
> > -LIBSPATIALINDEX_VERSION = 1.8.5
> > -LIBSPATIALINDEX_SITE = http://download.osgeo.org/libspatialindex
> > +LIBSPATIALINDEX_VERSION = 1.9.0
> > +LIBSPATIALINDEX_SITE = \
> > +     https://github.com/libspatialindex/libspatialindex/releases/download/$(LIBSPATIALINDEX_VERSION)
> >  LIBSPATIALINDEX_SOURCE = spatialindex-src-$(LIBSPATIALINDEX_VERSION).tar.bz2
> >  LIBSPATIALINDEX_INSTALL_STAGING = YES
> >  LIBSPATIALINDEX_LICENSE = MIT
> >  LIBSPATIALINDEX_LICENSE_FILES = COPYING
> > -
> > -# 0001-configure.ac-do-not-force-O2.patch
> > -LIBSPATIALINDEX_AUTORECONF = YES
> > +LIBSPATIALINDEX_CONF_OPTS = -DSIDX_BUILD_TESTS=OFF
> >
> >  LIBSPATIALINDEX_CXXFLAGS = $(TARGET_CXXFLAGS)
> >  LIBSPATIALINDEX_CONF_ENV = CXXFLAGS="$(LIBSPATIALINDEX_CXXFLAGS)"
>
>  I don't think this still works with CMake, you have to set
> -DCMAKE_CXX_FLAGS="$(LIBSPATIALINDEX_CXXFLAGS)"
Thanks, I missed this one.
>
>
>  It would be better to do the cmake conversion in a separate patch, if that is
> possible.
Tests fail to build, so I can't make two patches. However you're
right. I'll update the commit log with this information and the error
message.
>
>
>  Regards,
>  Arnout
>
> > @@ -21,4 +20,4 @@ ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_68485),y)
> >  LIBSPATIALINDEX_CXXFLAGS += -O0
> >  endif
> >
> > -$(eval $(autotools-package))
> > +$(eval $(cmake-package))
> >
Best Regards,

Fabrice


More information about the buildroot mailing list