[Buildroot] [PATCH] package/util-linux: revert logic regarding pam_selinux module

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sun Sep 15 14:00:36 UTC 2019


Hello Carlos,

On Sat, 14 Sep 2019 14:09:22 -0300
unixmania at gmail.com wrote:

> From: Carlos Santos <unixmania at gmail.com>
> 
> Leave pam_selinux enabled by default in su.pam and remove it from the
> /etc/pam.d/su and /etc/pam.d/su-l files if libselinux is not selected.
> 
> This prevents leaving a misleading line, even commented, referencing a
> PAM module that does not exist.

Just to make sure I understand: the motivation for this patch is just
to avoid the pam_selinux.so lines that remain present (but commented)
in the file when SELinux support is disabled ?

I.e, it is just cosmetic, but functional, correct ?

(This is not a criticism of the proposal, just an attempt to make sure
I'm not missing the point.)

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list