[Buildroot] [PATCH 1/1] package/kompexsqlite: fixup the 'v' prefix in the version

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sat Sep 14 14:03:23 UTC 2019


Hello Fabrice,

On Wed, 11 Sep 2019 19:22:56 +0200
Fabrice Fontaine <fontaine.fabrice at gmail.com> wrote:

> In order for the kompexsqlite version to match what is given by
> release-monitoring.org, the 'v' prefix should be encoded in
> KOMPEXSQLITE_SOURCE and not KOMPEXSQLITE_VERSION.
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>

I've applied to master, but I have a comment, see below.

> -KOMPEXSQLITE_VERSION = v1.10.12-1
> -KOMPEXSQLITE_SOURCE = $(KOMPEXSQLITE_VERSION).tar.gz
> +KOMPEXSQLITE_VERSION = 1.10.12-1
> +KOMPEXSQLITE_SOURCE = v$(KOMPEXSQLITE_VERSION).tar.gz
>  KOMPEXSQLITE_SITE = https://github.com/Aethelflaed/kompex-sqlite-wrapper/archive

When I look at
https://github.com/Aethelflaed/kompex-sqlite-wrapper/releases, to me it
seems like only the automatically generated tarballs are there. In such
cases, we should use the github macro instead.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list