[Buildroot] [PATCH v2] package/nfs-utils: enable IPv6 if libtirpc is selected

Arnout Vandecappelle arnout at mind.be
Tue Sep 10 07:06:56 UTC 2019



On 10/09/2019 01:56, unixmania at gmail.com wrote:
> From: Carlos Santos <unixmania at gmail.com>
> 
> IPv6 requires libtirpc but we don't want to select BR2_PACKAGE_LIBTIRPC
> inconditionally because it increases the size of system so enable IPv6

 unconditionally

> only if libtirpc is already selected.
> 
> Fixes: https://bugs.busybox.net/show_bug.cgi?id=10806
> 
> Signed-off-by: Carlos Santos <unixmania at gmail.com>
> ---
> CC: nathan.renniewaldock at gmail.com
> CC: Peter Seiderer <ps.report at gmx.net>
> CC: Arnout Vandecappelle <arnout at mind.be>
> CC: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> --
> Changes v1->v2

 This is v3, actually... v1 did the same as here (but without the
--enable-ipv6), v2 selected LIBTIRPC unconditionally.

> - Do not select libtirpc inconditionally
> ---
>  package/nfs-utils/nfs-utils.mk | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/nfs-utils/nfs-utils.mk b/package/nfs-utils/nfs-utils.mk
> index dc20942f71..3d5f5412cf 100644
> --- a/package/nfs-utils/nfs-utils.mk
> +++ b/package/nfs-utils/nfs-utils.mk
> @@ -19,7 +19,6 @@ NFS_UTILS_CONF_OPTS = \
>  	--disable-nfsv41 \
>  	--disable-gss \
>  	--disable-uuid \
> -	--disable-ipv6 \
>  	--without-tcp-wrappers \
>  	--with-statedir=/run/nfs \
>  	--with-rpcgen=internal
> @@ -51,11 +50,12 @@ else
>  NFS_UTILS_CONF_OPTS += --disable-caps
>  endif
>  
> +# IPv6 requires libtirpc

 Just to be sure: IPv6 really requires libtirpc, so the RPC implementation in
glibc is not enough?

 Assuming that this is the case:

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>


 Finally, a small nitpick remark: it would be good to update the Config.in help
text with this information. E.g.:

 	  The NFS Linux kernel server.
+
+	  For IPv6 support, select the libtirpc package.


 Regards,
 Arnout

>  ifeq ($(BR2_PACKAGE_LIBTIRPC),y)
> -NFS_UTILS_CONF_OPTS += --enable-tirpc
> +NFS_UTILS_CONF_OPTS += --enable-tirpc --enable-ipv6
>  NFS_UTILS_DEPENDENCIES += libtirpc
>  else
> -NFS_UTILS_CONF_OPTS += --disable-tirpc
> +NFS_UTILS_CONF_OPTS += --disable-tirpc --disable-ipv6
>  endif
>  
>  define NFS_UTILS_INSTALL_FIXUP
> 


More information about the buildroot mailing list