[Buildroot] [PATCH v2 2/4] package/python3: enable openssl support
Arnout Vandecappelle
arnout at mind.be
Sun Oct 27 21:14:13 UTC 2019
On 27/10/2019 22:05, Arnout Vandecappelle wrote:
>
>
> On 27/10/2019 16:50, Nicolas Carrier wrote:
>> On Sun, 2019-10-27 at 16:41 +0100, Thomas Petazzoni wrote:
>>> On Sun, 27 Oct 2019 15:39:08 +0000
>>> Nicolas Carrier <nicolas.carrier at orolia.com> wrote:
>>>
>>>> If a python script is ran or used as (or in) a custom script like
>>>> post
>>>> build, but requires ssl, then it will fail since it's explicitly
>>>> disabled
>>>> by default.
>>>>
>>>> This patch enables it unconditionnally.
>>>>
>>>> Signed-off-by: Nicolas Carrier <nicolas.carrier at orolia.com>
>>>>
>>>> ---
>>>>
>>>> Changes v1 -> v2:
>>>> - split the two original patches in two
>>>> - removed the ssl support option
>>>
>>> I don't understand. Why did you drop the SSL option ?
>>
>> We've discussed it a long time with Romain yesterday and ended up
>> deciding that since usually, there are no options added to host tools,
>> I wouldn't add one for host python and python 3.
>
> Usually, but not always :-). We already have a few which have suboptions.
>
> I checked the build time on my machine: 75s for host-python3, and 35s for
> host-openssl. So that it a significant increase. So (although I originally also
> thought that it was better to not make it optional), I agree with Thomas that
> openssl should only be built if explicitly requested.
I therefore applied v1 instead.
Regards,
Arnout
More information about the buildroot
mailing list