[Buildroot] [PATCH v4 1/1] package/libsodium: add config for full build

Peter Korsgaard peter at korsgaard.com
Thu Oct 24 08:30:05 UTC 2019


>>>>> "Arnout" == Arnout Vandecappelle <arnout at mind.be> writes:

Hi,

 >> I don't have a very clear-cut opinion.
 >> 
 >> On one hand, it is weird to have a Config.in option to reduce/remove
 >> something. But on the other hand, it makes sense to have Config.in
 >> options that are as much as possible mapped to the corresponding
 >> options provided by the package build system.
 >> 
 >> Arnout, Peter, any preference ?

 >  It was me who suggested to turn around the logic.

 >  I believe we have had problems in the past where there was some MINIMAL option,
 > but then some other package needed something from the non-minimal set. Then it
 > has to do a 'depends on' instead of a 'select'.

 >  So it's not a matter of being weird, it's a matter of making sure we don't
 > create problems in the future.

Agreed, having options to disable stuff gets tricky when you have other
packages needing the disabled stuff.

 >>> Also, we need to pass --disable-minimal in an "else" clause.

 >  This is still true. Adrien, I believe I did say something to that effect in an
 > earlier iteration, and I also believe you replied to it. But my memory is
 > worthless :-)

Getting old? :P

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list