[Buildroot] [PATCH] opensbi: Bump from 0.4 to 0.5

Alistair Francis alistair23 at gmail.com
Wed Oct 16 21:48:32 UTC 2019


On Tue, Oct 15, 2019 at 12:20 AM Thomas Petazzoni
<thomas.petazzoni at bootlin.com> wrote:
>
> Hello,
>
> On Mon, 14 Oct 2019 16:21:06 -0700
> Alistair Francis <alistair.francis at wdc.com> wrote:
>
> > diff --git a/board/qemu/riscv32-virt/patches/opensbi/0001-Makefile-Don-t-specify-mabi-or-march.patch b/board/qemu/riscv32-virt/patches/opensbi/0001-Makefile-Don-t-specify-mabi-or-march.patch
> > new file mode 100644
> > index 0000000000..5f554a6c24
> > --- /dev/null
> > +++ b/board/qemu/riscv32-virt/patches/opensbi/0001-Makefile-Don-t-specify-mabi-or-march.patch
>
> Why is this patch in board/qemu/riscv32-virt/ ? It doesn't seem to be
> specific to that particular platform, so anybody building opensbi for
> another RV32 platform would also hit the issue. Shouldn't the patch (in
> this form or another) be in boot/opensbi/ ?

Good point, I'll move it there.

>
> Also minor nit: the commit title should be:
>
>         boot/opensbi: bump to 0.5

Fixed.

>
> You could also send a patch adding the hash for the license file in
> opensbi.hash.

Will do!

Alistair

>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com


More information about the buildroot mailing list