[Buildroot] [PATCH 1/1] package/bird: select at least one protocol

[Thomas Petazzoni]

Hello,

I'd like to have the review of Adrien on this patch. Adrien, could you
comment? Also, I have my own comment, see below.

On Tue, 15 Oct 2019 21:23:03 +0200
Fabrice Fontaine <fontaine.fabrice at gmail.com> wrote:

> bird needs at least one protocol so select BGP if no other protocols are
> selected as BGP is already the default one
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/0b00948eed9bb8405b70f3f9112ecce99b365f35
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> ---
>  package/bird/Config.in | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/package/bird/Config.in b/package/bird/Config.in
> index c2951c74c3..3baf43f98e 100644
> --- a/package/bird/Config.in
> +++ b/package/bird/Config.in
> @@ -1,6 +1,11 @@
>  config BR2_PACKAGE_BIRD
>  	bool "bird"
>  	depends on BR2_USE_MMU # fork()
> +	select BR2_PACKAGE_BIRD_BGP if !(BR2_PACKAGE_BIRD_BABEL || \
> +		BR2_PACKAGE_BIRD_BFD || BR2_PACKAGE_BIRD_MRT || \
> +		BR2_PACKAGE_BIRD_OSPF || BR2_PACKAGE_BIRD_PERF || \
> +		BR2_PACKAGE_BIRD_PIPE || BR2_PACKAGE_BIRD_RADV || \
> +		BR2_PACKAGE_BIRD_RIP || BR2_PACKAGE_BIRD_STATIC)

This is not so nice. Perhaps we could do it like this:

config BR2_PACKAGE_BIRD_AT_LEAST_ONE_PROTOCOL
	bool

config BR2_PACKAGE_BIRD
	bool "bird"
	...
	select BR2_PACKAGE_BIRD_BGP if !BR2_PACKAGE_BIRD_AT_LEAST_ONE_PROTOCOL

if BR2_PACKAGE_BIRD

config BR2_PACKAGE_BIRD_BGP
	bool "bgp"
	select BR2_PACKAGE_BIRD_AT_LEAST_ONE_PROTOCOL

...

endif

Does this work ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com