[Buildroot] [PATCH 1/1] scanpypi: write every license file once

Yegor Yefremov yegorslists at googlemail.com
Thu Oct 10 08:38:04 UTC 2019


Hello Thomas,

On Thu, Oct 10, 2019 at 9:29 AM Thomas Petazzoni
<thomas.petazzoni at bootlin.com> wrote:
>
> Hello Yegor,
>
> On Wed, 9 Oct 2019 19:36:23 +0200
> Yegor Yefremov <yegorslists at googlemail.com> wrote:
>
> > > There are two checks to see if the manual gpio is configured, but
> > > these the check is seeing if the structure is NULL instead it
> > > should check to see if there are CTS and/or RTS pins defined.
> > >
> > > This patch uses checks for those individual pins instead of
> > > checking for the structure itself to restore auto RTS/CTS.
> > >
> > > Signed-off-by: Adam Ford <aford173 at gmail.com>
>
> Is that a bad copy/paste ? It seems like you were working on some
> serial port kernel commits at the same time, isn't it ? :-)

Every time I try to copy/paste something on a laptop I get similar
results. Sorry for that.

Yegor

> > Reviewed-by: Yegor Yefremov <yegorslists at googlemail.com>
>
> Anyway, thanks for the review! :-)
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com


More information about the buildroot mailing list