[Buildroot] [PATCH 1/1] package/libftdi1: drop second patch

Fabrice Fontaine fontaine.fabrice at gmail.com
Wed Oct 2 21:19:38 UTC 2019


Hello Thomas,

Le mer. 2 oct. 2019 à 21:01, Thomas Petazzoni
<thomas.petazzoni at bootlin.com> a écrit :
>
> On Wed,  2 Oct 2019 18:47:00 +0200
> Fabrice Fontaine <fontaine.fabrice at gmail.com> wrote:
>
> > Second patch is not needed anymore as the only, optional, dependency of
> > libusb is udev which can't be built statically
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> > ---
> >  ...check-for-g-when-FTDIPP-is-disabled.patch} |  0
> >  .../0002-cmake-fix-FindUSB1.cmake.patch       | 34 -------------------
> >  ...-swig.patch => 0003-cmake-find-swig.patch} |  0
> >  3 files changed, 34 deletions(-)
> >  rename package/libftdi1/{0003-cmake-do-not-check-for-g-when-FTDIPP-is-disabled.patch => 0002-cmake-do-not-check-for-g-when-FTDIPP-is-disabled.patch} (100%)
> >  delete mode 100644 package/libftdi1/0002-cmake-fix-FindUSB1.cmake.patch
> >  rename package/libftdi1/{0004-cmake-find-swig.patch => 0003-cmake-find-swig.patch} (100%)
>
> Applied to master, thanks. I'm curious, how did you notice that this
> patch was no longer needed?
I tried to upstream this patch. They did not like the usage of
PC_LIBUSB_STATC_xxx variables so I was working on a more simple
approach using PC_LIBUSB_LIBRARIES but then I discovered that libftdi1
was building perfectly fine with libusb and that I could not enable
udev in static build.
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,

Fabrice


More information about the buildroot mailing list