[Buildroot] [PATCH 1/1] package/ntp: remove host shell check
James Byrne
james.byrne at origamienergy.com
Tue Nov 26 11:24:36 UTC 2019
Hi Yann,
On 23/11/2019 10:30, Yann E. MORIN wrote:
> This is not nice, as this patch can't be upstreamed, and we'll have tio
> live with it for the eons to come.
>
> What about using AC_CACHE_CHECK [0] to do the check, which can be
> overriden on the command line. For example:
>
> [
> AC_CACHE_CHECK([for a posix-compliant shell], [ntp_ac_cv_posix_shell],
> [while :
> do
> blablabla
> done
> ])
> AC_DEFINE_UNQUOTED([POSIX_SHELL], ["${ntp_ac_cv_posix_shell}"],
> [define to a working POSIX compliant shell])
> ]
>
> And then in ntp.mk we could do (in addition to the existing one, of
> course):
>
> NTP_CONF_ENV = ntp_ac_cv_posix_shell=/bin/sh
>
> And such a patch will probably be more acceptable for upstream.
Your comments prompted me to do some more digging, and it turns out that
the issue has been addressed in a later version of AutoGen, which is
where the issue comes from - see the change to libopts.def in:
https://sourceforge.net/p/autogen/code/ci/e51f2a781500236b2ba92a4ccd854771a7c28b61/
I will resubmit a V2 patch based on pulling in this change, then if the
upstream ntp package is updated to use a newer version of AutoGen at
some point in the future, the patch can go away.
Regards,
James
More information about the buildroot
mailing list