[Buildroot] [EXT] Re: [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package

[Michael Walle]

Am 2019-11-26 11:12, schrieb Thomas Petazzoni:
> On Tue, 26 Nov 2019 10:29:18 +0100
> Michael Walle <michael at walle.cc> wrote:
> 
>> >> Final semi-colon not needed.
>> > Will use below command in v3:
>> > define QORIQ_CADENCE_DP_FIRMWARE_EXTRACT_CMDS
>> >         $(call
>> > NXP_QORIQ_EXTRACT_HELPER,$(QORIQ_CADENCE_DP_FIRMWARE_DL_DIR)/$(QORIQ_CADENCE_DP_FIRMWARE_SOURCE))
>> > endef
>> 
>> please don't duplicate that piece of code.. it should really be
>> NXP_EXTRACT_HELPER. which leads to the cleanup of the freescale-imx
>> and nxp-qoriq directories. IMHO both should be named consistently.
>> Thomas? Matthew?
> 
> What are you suggesting? A single package/nxp/ folder, with everything
> in there?

correct. that would also solve the NXP_EXTRACT_HELPER thing. which would 
end up in
package/nxp/helper.mk or something like that.

> If we do package/nxp-imx/ and package/nxp-qoirq/, then there is still
> the question of where to put this common NXP_EXTRACT_HELPER macro

yes. see above.

-michael