[Buildroot] [PATCH v2 2/2] package/python-esptool: new package

[Bartosz Bilas]

Hello guys,

On 08.11.2019 09:49, Thomas Petazzoni wrote:
> Hello,
>
> +Yegor in Cc.
>
> On Fri, 8 Nov 2019 09:45:50 +0100
> Bartosz Bilas <b.bilas at grinn-global.com> wrote:
>
>>>> +PYTHON_ESPTOOL_LICENSE = GNU General Public License v2 or later (GPLv2+)
>>> The proper way to describe this is just:
>>>
>>> PYTHON_ESPTOOL_LICENSE = GPL-2.0+
>> this was created using scanpypi script so do you think we should fix
>> that script or adjust that manually as you did?
> scanpipy already has a conversion table between Pipy-provided license
> strings and Buildroot license tags:
>
>                  'Apache Software License': 'Apache-2.0',
>                  'BSD License': 'FIXME: please specify the exact BSD version',
>                  'European Union Public Licence 1.0': 'EUPL-1.0',
>                  'European Union Public Licence 1.1': 'EUPL-1.1',
>                  "GNU General Public License": "GPL",
>                  "GNU General Public License v2": "GPL-2.0",
>                  "GNU General Public License v2 or later": "GPL-2.0+",
>                  "GNU General Public License v3": "GPL-3.0",
>                  "GNU General Public License v3 or later": "GPL-3.0+",
>                  "GNU Lesser General Public License v2": "LGPL-2.1",
>                  "GNU Lesser General Public License v2 or later": "LGPL-2.1+",
>                  "GNU Lesser General Public License v3": "LGPL-3.0",
>                  "GNU Lesser General Public License v3 or later": "LGPL-3.0+",
>                  "GNU Library or Lesser General Public License": "LGPL-2.0",
>                  "ISC License": "ISC",
>                  "MIT License": "MIT",
>                  "Mozilla Public License 1.0": "MPL-1.0",
>                  "Mozilla Public License 1.1": "MPL-1.1",
>                  "Mozilla Public License 2.0": "MPL-2.0",
>                  "Zope Public License": "ZPL"
>
> Obviously, the value "GNU General Public License v2 or later (GPLv2+)"
> that was used by this package didn't match any entry in this table.
> Since "GNU General Public License v2 or later (GPLv2+)" is apparently
> rarely used, I don't think it's worth adding an entry to the table: for
> such cases, we simply have to do a manual fixup. In any case,
> ./utils/scanpipy does not guarantee that it provides a fully working
> and correct Buildroot package: it extracts most information from Pipy,
> but a careful review, and possibly some changes may be necessary.

I assume that's the same for that comment bellow:

 > +config BR2_PACKAGE_PYTHON_ESPTOOL
 > +    bool "python-esptool"
 > +    select BR2_PACKAGE_PYTHON_SERIAL # runtime
 > +    select BR2_PACKAGE_PYTHON_PYAES # runtime
 > +    select BR2_PACKAGE_PYTHON_ECDSA # runtime

Alphabetic ordering.

but I think it wouldn't be difficult to handle it in the script.

Best
Bartek
>
> Best regards,
>
> Thomas