[Buildroot] [External] [PATCH v2 1/2] package/netdata: new package

Matthew Weber matthew.weber at rockwellcollins.com
Mon Nov 4 21:50:25 UTC 2019


On Mon, Nov 4, 2019 at 4:42 AM Marcin Niestrój
<m.niestroj at grinn-global.com> wrote:
>
> Hi Matt,
>
> Marcin Niestrój <m.niestroj at grinn-global.com> writes:
>
> > Hi Matt,
> >
> > [snip]
> >
> > So in order to do things properly we would need to ask netdata about
> > their prefered build system for future and do improvements there :)
> >
>
> Looking at Github issues there is an ongoing effort to support cmake as
> the main build system. So I would go with autotools for now and add
> patch that removes .keep installation. In future we can convert to cmake
> if that will be ready in next netdata release. Then we will drop
> Buildroot specific patch and do improvements in cmake installation if
> neccessary. What do you think about that?

Ah that is a good catch, if they are changing we'll have to integrate
this again soon.  I'd suggest putting in a ticket to bring visibility
to this .keep collision such that they don't keep it in the cmake
update.  Then you can reference that ticket as your upstream issue/bug
in your patch in buildroot.

Matt


More information about the buildroot mailing list