[Buildroot] [PATCH 1/1] boot/barebox: add hash for the license file

Arnout Vandecappelle arnout at mind.be
Wed May 29 20:52:17 UTC 2019



On 29/05/2019 10:14, Thomas Huth wrote:
> Am Tue, 28 May 2019 20:16:42 +0200
> schrieb Arnout Vandecappelle <arnout at mind.be>:
> 
>>
>>
>> On 28/05/2019 18:53, Bartosz Biłas wrote:
>>> There is also BSD-3-Clause used in some files so there is necessity
>>> to complete licence files with them. I will prepare a new patch
>>> with that.
>>
>>  Can you also check (and specify in the commit message) if this file
>> exists in *all* versions of barebox? It is possible to configure a
>> custom version of barebox, so it can be pretty much anything...
>>
>>  Well, I checked myself: the LICENSES directory exists since
>> 2019.04.0...
>>
>>  There is unfortunately no simple way to conditionally add license
>> files: if a file specified in _LICENSE_FILES doesn't exist, it's a
>> hard error. You can use $(wildcard ...) but then you have to strip
>> off the source directory again.
> 
> Hmm, don't we have the problem with the hash of the tarball itself
> already? If you specify another version, the hash of the tar.bz2 file
> certainly does not match anymore...

 The hash of the tarball isn't checked for custom versions:

ifeq ($(BR2_TARGET_BAREBOX)$(BR2_TARGET_BAREBOX_LATEST_VERSION),y)
BR_NO_CHECK_HASH_FOR += $(BAREBOX_SOURCE)
endif


 Regards,
 Arnout


More information about the buildroot mailing list