[Buildroot] [PATCH V3 01/10] arch/csky: Use VDSP instead of DSP

Guo Ren guoren at kernel.org
Wed May 29 07:30:45 UTC 2019


OK, two pathes.

On Wed, May 29, 2019 at 3:21 PM Thomas Petazzoni
<thomas.petazzoni at bootlin.com> wrote:
>
> Hello Guo,
>
> Thanks for this new iteration. I apologize, but unfortunately it's
> still not good, and doesn't match the suggestions I did.
>
> On Wed, 29 May 2019 15:18:39 +0800
> guoren at kernel.org wrote:
>
> > From: Guo Ren <ren_guo at c-sky.com>
> >
> > Use VDSP enhanced instructions Co-processor instead of DSP.
>
> Your commit log should explain why.
>
> > Signed-off-by: Guo Ren <ren_guo at c-sky.com>
> > ---
> >  arch/Config.in.csky | 17 +++--------------
> >  arch/arch.mk.csky   | 24 ++++++++++++++++++++++++
>
> The change to using arch.mk.csky should be done separately. So this
> commit should be split into two:
>
>  - One switching to using arch.mk.sky, without changing DSP -> VDSP
>
>  - A follow-up one changing DSP -> VDSP, with a commit log that
>    explains why you make this chang
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com


More information about the buildroot mailing list