[Buildroot] [PATCH v2, 1/1] package/wireshark: fix static build with snappy

[Fabrice Fontaine]

Dear Thomas and Arnout,

Le mar. 28 mai 2019 à 22:42, Thomas Petazzoni
<thomas.petazzoni at bootlin.com> a écrit :
>
> Hello,
>
> On Tue, 28 May 2019 22:32:30 +0200
> Fabrice Fontaine <fontaine.fabrice at gmail.com> wrote:
>
> > Fixes:
> >  - http://autobuild.buildroot.org/results/419468f0d7d3c2b64d420513aa9505c6de097ed2
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> > ---
> > Changes v1 -> v2 (after review of Arnout Vandecappelle):
> >  - Set linker to CXX instead of adding -lstdc++ to LIBS
>
> Is this really the right thing to do? Ideally a program written in C
> should not have to know that a library it is using is written in C++.
>
> We already had a similar situation in Buildroot, and so far we have
> added -lstdc++. For example:
>
> ifeq ($(BR2_PACKAGE_DIRECTFB),y)
> LINKS_CONF_ENV = ac_cv_path_DIRECTFB_CONFIG=$(STAGING_DIR)/usr/bin/directfb-config
> ifeq ($(BR2_STATIC_LIBS),y)
> LINKS_CONF_ENV += LIBS=-lstdc++
>
> and there's a few other examples in the tree. To be honest, I don't
> know what is the most correct solution, I'm just trying to make sure we
> solve a given problem in the same way everywhere.
I don't know either. You can apply the first or the second version of
this patch.
Then, I'll send the chosen version upstream. If they don't like it,
I'll have the second solution as a fallback.
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,

Fabrice