[Buildroot] [PATCH v2 02/12] package/atop: fix BUG_85180 build timeout

[Giulio Benetti]

Hello,

Il 22/05/2019 23:07, Thomas Petazzoni ha scritto:
> Hello Giulio,
> 
> On Tue, 21 May 2019 15:39:22 +0200
> Giulio Benetti <giulio.benetti at micronovasrl.com> wrote:
> 
>> With Microblaze Gcc version < 8.x build hangs on compiling last files
>> before linking. This is due to bug 85180:
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
>> Bug shows up building atop with optimization but not when building with
>> -O0.
>>
>> If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
>> CFLAGS.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/94a/94aa00f776b8a3491ac0b3212c95f5e666c5a29a/
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti at micronovasrl.com>
> 
> I have applied to master after reworking the commit title and commit
> log,

Again... Need to improve commit logs.

> and also adjusting the code a bit (see below).
> 
>> diff --git a/package/atop/atop.mk b/package/atop/atop.mk
>> index aaf02908c4..afce71f6cb 100644
>> --- a/package/atop/atop.mk
>> +++ b/package/atop/atop.mk
>> @@ -10,8 +10,13 @@ ATOP_LICENSE = GPL-2.0+
>>   ATOP_LICENSE_FILES = COPYING
>>   ATOP_DEPENDENCIES = ncurses zlib
>>   
>> +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
>> +ATOP_CFLAGS += $(TARGET_CFLAGS) -O0
>> +endif
> 
> I believe:
> 
> ATOP_CFLAGS = $(TARGET_CFLAGS)
> 
> ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
> ATOP_CFLAGS += -O0
> endif
> 
> is more correct, otherwise you pass an empty CFLAGS when
> BR2_TOOLCHAIN_HAS_GCC_BUG_85180 is false.

Yes totally right. Then I need to modify other patches for 
$(generic-package) packages as well as their commit logs at this point.

> 
>> +
>>   define ATOP_BUILD_CMDS
>> -	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
>> +	$(MAKE) $(TARGET_CONFIGURE_OPTS) CFLAGS="$(ATOP_CFLAGS)" \
>> +	-C $(@D)
> 
> The second line is typically indented with one more tab.

Ok. I've never noticed it. Thanks for pointing.

Best regards!
-- 
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale € 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

> As I said, I've applied to master after fixing those issues.
> 
> Thanks!
> 
> Thomas
>