[Buildroot] [arc-buildroot] [PATCH] linux-tools/perf: Respect TARGET_CFLAGS

Alexey Brodkin Alexey.Brodkin at synopsys.com
Wed May 8 14:54:13 UTC 2019


Hi Yann,

> -----Original Message-----
> From: Yann E. MORIN <yann.morin.1998 at free.fr>
> Sent: Wednesday, May 8, 2019 5:31 PM
> To: Alexey Brodkin <abrodkin at synopsys.com>
> Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>; buildroot at busybox.net; ARC Buildroot mailing list
> <arc-buildroot at synopsys.com>; Arnout Vandecappelle <arnout at mind.be>
> Subject: Re: [arc-buildroot] [Buildroot] [PATCH] linux-tools/perf: Respect TARGET_CFLAGS
> 
> Alexey, All,
> 
> On 2019-05-08 13:19 +0000, Alexey Brodkin spake thusly:
> > From: Yann E. MORIN <yann.morin.1998 at gmail.com> On Behalf Of Yann E. MORIN
> [--SNIP--]
> > > I'm not too fond of this, but what about the following:
> > >
> > > diff --git a/arch/arch.mk.arc b/arch/arch.mk.arc
> > > new file mode 100644
> > > index 0000000000..83503841b6
> > > --- /dev/null
> > > +++ b/arch/arch.mk.arc
> > > @@ -0,0 +1,3 @@
> > > +ifeq ($(BR2_arcle),y)
> > > +ARCH_TOOLCHAIN_WRAPPER_OPTS = -matomic
> > > +endif
> > > diff --git a/toolchain/toolchain-wrapper.mk
> > > b/toolchain/toolchain-wrapper.mk
> > > index ca66fa7ba4..8f872506ec 100644
> > > --- a/toolchain/toolchain-wrapper.mk
> > > +++ b/toolchain/toolchain-wrapper.mk
> > > @@ -17,6 +17,7 @@ TOOLCHAIN_WRAPPER_ARGS =
> > > $($(PKG)_TOOLCHAIN_WRAPPER_ARGS)
> > >  TOOLCHAIN_WRAPPER_ARGS += -DBR_SYSROOT='"$(STAGING_SUBDIR)"'
> > >
> > >  TOOLCHAIN_WRAPPER_OPTS = \
> > > +   $(ARCH_TOOLCHAIN_WRAPPER_OPTS) \
> > >     $(call qstrip,$(BR2_SSP_OPTION)) \
> > >     $(call qstrip,$(BR2_TARGET_OPTIMIZATION))
> >
> > That looks good to me with only one change: prefer generic "BR2_arc"
> > instead of little-endian only "BR2_arcle".
> 
> Yes, of course, it was just a quicky to demo what I was thinking...
> 
> > Care to send-out a patch?
> 
> Aw... But *you* are the arc guy! ;-)
> 
> OK, will do.

I'm all for sending it myself but it will be like I'm stealing
your nice idea - nothing more that that.

Want me to do that instead?

-Alexey


More information about the buildroot mailing list