[Buildroot] [next/testing Lua modules 01/11] luarocks: add generation of test

[François Perrad]

Le jeu. 28 mars 2019 à 17:22, Thomas Petazzoni <thomas.petazzoni at bootlin.com>
a écrit :

> Hello François,
>
> On Tue, 19 Feb 2019 16:43:01 +0100
> Francois Perrad <fperrad at gmail.com> wrote:
>
> > Signed-off-by: Francois Perrad <francois.perrad at gadz.org>
> > ---
> >  package/luarocks/buildroot.lua | 60 ++++++++++++++++++++++++++++++++++
> >  1 file changed, 60 insertions(+)
>
> I have applied this entire series, thanks! It's going in the good
> direction, but I found some odd things.
>
> The lpeg test looks like this:
>
> +        self.module_test("lpeg",
> script="print(require[[lpeg]].version())")
>
> which clearly cannot have been generated by the Luarocks "buildroot"
> script, which does only:
>
> +   f:write('        self.module_test("' .. modname .. '")\n')
>
> Also, I've used "lpeg-upgrade" and "rings-upgrade" as tests, and
> noticed some differences:
>
> -        self.module_test("lpeg",
> script="print(require[[lpeg]].version())")
> +        self.module_test("LPeg")
>
> So we have the difference I explained above + a difference in the
> casing of the module.
>
> We have the same casing difference with rings:
>
> -        self.module_test("rings")
> +        self.module_test("Rings")
>
> Is this expected ?
>

Yes, more or less.

The lua ecosystem has no common policy about naming, etc...
So, a generated stuff sometime needs a manual editing.

François


> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190328/6dcc32fc/attachment.html>