[Buildroot] [next/testing Lua modules 01/11] luarocks: add generation of test

Thomas Petazzoni thomas.petazzoni at bootlin.com
Thu Mar 28 16:22:29 UTC 2019


Hello François,

On Tue, 19 Feb 2019 16:43:01 +0100
Francois Perrad <fperrad at gmail.com> wrote:

> Signed-off-by: Francois Perrad <francois.perrad at gadz.org>
> ---
>  package/luarocks/buildroot.lua | 60 ++++++++++++++++++++++++++++++++++
>  1 file changed, 60 insertions(+)

I have applied this entire series, thanks! It's going in the good
direction, but I found some odd things.

The lpeg test looks like this:

+        self.module_test("lpeg", script="print(require[[lpeg]].version())")

which clearly cannot have been generated by the Luarocks "buildroot"
script, which does only:

+   f:write('        self.module_test("' .. modname .. '")\n')

Also, I've used "lpeg-upgrade" and "rings-upgrade" as tests, and
noticed some differences:

-        self.module_test("lpeg", script="print(require[[lpeg]].version())")
+        self.module_test("LPeg")

So we have the difference I explained above + a difference in the
casing of the module.

We have the same casing difference with rings:

-        self.module_test("rings")
+        self.module_test("Rings")

Is this expected ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list