[Buildroot] [PATCH] core/pkg-infra: tweak only .la files that need it

Peter Korsgaard peter at korsgaard.com
Wed Mar 27 14:28:04 UTC 2019


>>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:

 > Currently, when we tweak the .la files, we do so unconditionally on all
 > .la files, even those we already fixed in a previous run.

 > This has the nasty side effect that each .la file will be reported as
 > being touched by all packages that are installed after the package that
 > actually installed said .la file.

 > Since we can't easily know what files were installed by a package (that
 > is an instrumentation hook, and comes after the mangling), we use a
 > trick (like is done in libtool?): we do mangle all files, each into a
 > temporary location; if the result is identical to the input, we remove
 > the temporary, while if the result differs from the output, we move
 > the temporary to replace the input.

 > Reported-by: Nicolas Cavallari <nicolas.cavallari at green-communications.fr>
 > Reported-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
 > Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
 > Cc: Nicolas Cavallari <nicolas.cavallari at green-communications.fr>
 > Cc: Thomas De Schampheleire <patrickdepinguin at gmail.com>
 > Cc: Arnout Vandecappelle <arnout at mind.be>

 > ---
 > Changes v1 -> v2:
 >   - drop spurious trailing semicolon on sed command line  (Thomas DS.)
 >   - use $$(find ...) instead of $(find ...), as we don't want it to be
 >     evaluated by the Makefile, but by the shell
 >   - silence the output of cmp
 >   - typoes in commit log  (Thomas DS.)

Committed to 2019.02.x, thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list