[Buildroot] [git commit] go: explicitly disable modules to avoid unintended network lookup

Peter Korsgaard peter at korsgaard.com
Sun Mar 17 22:08:22 UTC 2019


>>>>> "Peter" == Peter Korsgaard <peter at korsgaard.com> writes:

 > commit: https://git.buildroot.net/buildroot/commit/?id=f7a2870dd1fef9ee41e78ea1bcbb2ec61e82eb67
 > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

 > Go "modules" refers to the dependency fetching, verification (hashing), and
 > version control system built into Go as of 1.11.

 > It is not desirable to have Go modules enabled in Buildroot in the normal case,
 > as Buildroot manages downloading the sources, and third party dependency
 > managers are typically not used.

 > In the absence of the GO111MODULE environment variable, the Go compiler will
 > correctly compile using the "vendor" version of dependencies downloaded by
 > Buildroot during the compilation process for Go-based packages.

 > However, if the user sets the GO111MODULE=on environment variable, the Go
 > compiler will download the Go dependencies for Buildroot packages, using the
 > modules system. This is potentially unintended behavior from user environment
 > variables.

 > This commit sets the GO111MODULE=off variable in the Go target and host
 > compilation environments, disabling Go modules support for Buildroot mainline
 > packages.

 > Signed-off-by: Christian Stewart <christian at paral.in>
 > Signed-off-by: Peter Korsgaard <peter at korsgaard.com>

Committed to 2018.11.x, thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list