[Buildroot] [PATCH 14/19] autobuild-run: move log variable to Builder class

Arnout Vandecappelle arnout at mind.be
Tue Jun 25 14:20:48 UTC 2019



On 21/06/2019 10:47, Atharva Lele wrote:
> Signed-off-by: Atharva Lele <itsatharva at gmail.com>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>

[snip]
> +        log_write(self.log, "INFO: preparing a new build")

 Since log_write is now only used within the Builder class, it would be nice to
convert it into a member of that class, so the calls become

        self.log_write("INFO: preparing for a new build")

 But that's really a nice-to-have so don't put it on your priority list :-)

 Regards,
 Arnout

[snip]


More information about the buildroot mailing list