[Buildroot] [PATCH 03/19] autobuild-run: move njobs from kwargs to Builder class

[Arnout Vandecappelle]

On 21/06/2019 10:47, Atharva Lele wrote:
> Signed-off-by: Atharva Lele <itsatharva at gmail.com>
> ---
>  scripts/autobuild-run | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/scripts/autobuild-run b/scripts/autobuild-run
> index 291cd9f..82b8f45 100755
> --- a/scripts/autobuild-run
> +++ b/scripts/autobuild-run
> @@ -271,8 +271,9 @@ class SystemInfo:
>          return not missing_requirements
>  
>  class Builder:
> -    def __init__(self, instance):
> +    def __init__(self, instance, njobs):
>          self.instance = instance
> +        self.njobs = njobs
>  
>      def prepare_build(self, **kwargs):
>          """Prepare for the next build of the specified instance
> @@ -455,7 +456,7 @@ class Builder:
>          cmd = ["nice", "-n", str(nice),
>                  "make", "O=%s" % outputdir,
>                  "-C", srcdir, "BR2_DL_DIR=%s" % dldir,
> -                "BR2_JLEVEL=%s" % kwargs['njobs']] \
> +                "BR2_JLEVEL=%s" % self.njobs] \
>              + kwargs['make_opts'].split()
>          sub = subprocess.Popen(cmd, stdout=f, stderr=f)
>  
> @@ -843,9 +844,8 @@ def main():
>      buildpid = multiprocessing.Array('i', int(args['--ninstances']))
>      processes = []
>      for i in range(0, int(args['--ninstances'])):
> -        builder = Builder(i)
> +        builder = Builder(i, args['--njobs'])

 Since there will be a lot of arguments in the end, it would be better to make
it more explicit, similar like it was in kwargs, i.e.

     builder = Builder(i
         njobs = args['--njobs'])

 Still, not essential, so

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>

 Regards,
 Arnout

>          p = multiprocessing.Process(target=builder.run_instance, kwargs=dict(
> -                njobs = args['--njobs'],
>                  sysinfo = sysinfo,
>                  http_url = args['--http-url'],
>                  http_login = args['--http-login'],
>