[Buildroot] [PATCH v4 1/4] autobuild-run: move creation of result directory to run_instance()

Yann E. MORIN yann.morin.1998 at free.fr
Fri Jun 14 20:26:26 UTC 2019


Atharva, All,

On 2019-06-14 16:25 +0530, Atharva Lele spake thusly:
> We need the result directory to be present when the check_reproducibility()
> function (implemented in the next patch) executes. As of now the results
> directory is created in the send_results() function which executes after
> check_reproducibility() will.
> 
> Signed-off-by: Atharva Lele <itsatharva at gmail.com>

Reviewed-by: Yann E. MORIN <yann.morin.1998 at free.fr>

Regards,
Yann E. MORIN.

> ---
> Changes v4: Add new patch to series
> ---
>  scripts/autobuild-run | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/autobuild-run b/scripts/autobuild-run
> index ef2f2a5..190a254 100755
> --- a/scripts/autobuild-run
> +++ b/scripts/autobuild-run
> @@ -470,8 +470,6 @@ def send_results(result, **kwargs):
>      srcdir = os.path.join(idir, "buildroot")
>      resultdir = os.path.join(outputdir, "results")
>  
> -    os.mkdir(resultdir)
> -
>      shutil.copyfile(os.path.join(outputdir, ".config"),
>                      os.path.join(resultdir, "config"))
>      shutil.copyfile(os.path.join(outputdir, "defconfig"),
> @@ -647,6 +645,9 @@ def run_instance(**kwargs):
>          if ret != 0:
>              continue
>  
> +        resultdir = os.path.join(idir, "output", "results")
> +        os.mkdir(resultdir)
> +
>          ret = gen_config(**kwargs)
>          if ret != 0:
>              log_write(kwargs['log'], "WARN: failed to generate configuration")
> -- 
> 2.20.1
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'


More information about the buildroot mailing list