[Buildroot] [git commit] package/brotli: work around gcc bug 68485

Peter Korsgaard peter at korsgaard.com
Fri Jun 7 06:52:59 UTC 2019


>>>>> "Giulio" == Giulio Benetti <giulio.benetti at micronovasrl.com> writes:

Hi,

 >> > +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_68485),y)
 >> > +BROTLI_CONF_OPTS += -DCMAKE_C_FLAGS="-O0"
 >> 
 >> Hmm, why is this not "$(TARGET_C_FLAGS) -O0" like for the other
 >> packages?

 > Because CFLAGS were needed only once in that package.

Yes, but we should still pass TARGET_CFLAGS as well.

 > Anyway, if you say, I can modify it and use a BROTLI_CFLAGS
 > intermediate variable.

That is less important, but we shouldn't drop TARGET_CFLAGS.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list