[Buildroot] [PATCH 1/1] package/mender-artifact: fix lzma detection

[Fabrice Fontaine]

Hello,

Le mer. 5 juin 2019 à 09:36, Mirza Krak <mirza.krak at northern.tech> a écrit :
>
> On Tue, Jun 4, 2019 at 11:08 PM Fabrice Fontaine
> <fontaine.fabrice at gmail.com> wrote:
> >
> > Use CGO_CFLAGS and CGO_LDFLAGS to help mender-artifact to find lzma.h
> > and link with liblzma (with a correct rpath)
> >
> > Fixes:
> >  - http://autobuild.buildroot.org/results/b436d50a11687afa7021efc7eedd24fc337b0994
>
> I also sent a patch [1] trying to resolve these build errors, but my
> approach was to patch the pkg-golang.mk instead of mender-artifact.mk
> as I would expect this problem to exist for any golang host package
> that is using CGO, and is not isolated to mender-artifact.mk (though
> is is probably the only package in Buildroot that does use CGO in host
> environment).
I missed your patch, I think your approach is better and so I'll set
my patch as Not Applicable.
However, your patch will add HOST_{C,LD}FLAGS to CGO_{C,LD}FLAGS for
host but also for target packages. I think this modification should be
done only for host packages. Moreover, you didn't get any rpath
related errors?
>
>
> [1]. https://patchwork.ozlabs.org/patch/1109161/
> --
> Mirza Krak | Embedded Solutions Architect | https://mender.io
>
>  Northern.tech AS | @northerntechHQ
Best Regards,

Fabrice