[Buildroot] [PATCH] package/qt5/qt5webengine: fix build error

Thomas Petazzoni thomas.petazzoni at bootlin.com
Tue Jul 30 14:03:59 UTC 2019


Hello Bartosz,

Thanks for your patch, see below for some questions.

On Tue, 30 Jul 2019 13:58:32 +0200
Bartosz Bilas <b.bilas at grinn-global.com> wrote:

> This commit adds a patch from upstream chromium
> and bumps required minimal gcc version to 8.
> 
> Fixes:
>   ../../3rdparty/chromium/third_party/skia/third_party/skcms/skcms.cc:1909:16:
>   note: in definition of macro 'NS'
>   #define NS(id) id
>                 ^~
> 
> Signed-off-by: Bartosz Bilas <b.bilas at grinn-global.com>

Do we have any corresponding build failure in the autobuilders ? If so,
we like to have a reference to such build failures.

Also, why is the required gcc version now >= 8.x ? This is not really
explained in your commit log.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list