[Buildroot] [PATCH] package/python-idna: select PYTHON3_UNICODEDATA

Thomas Petazzoni thomas.petazzoni at bootlin.com
Wed Jul 17 06:43:47 UTC 2019


Hello Alex,

On Tue, 16 Jul 2019 13:58:30 -0400
"Alex Xu (Hello71)" <alex_y_xu at yahoo.ca> wrote:

> Signed-off-by: Alex Xu (Hello71) <alex_y_xu at yahoo.ca>

Thanks for your patch. However, the commit log is empty, and therefore
it doesn't carry any explanation as to why this change is necessary.
Could you give more details ?

> diff --git a/package/python-idna/Config.in b/package/python-idna/Config.in
> index 1fd56ceaf6..c247fa89d0 100644
> --- a/package/python-idna/Config.in
> +++ b/package/python-idna/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_PYTHON_IDNA
>  	bool "python-idna"
> +        select BR2_PACKAGE_PYTHON3_UNICODEDATA

Nit: there is an indentation problem, we indent those lines with a tab,
not with spaces.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list